Fix Android composer padding: Director's Cut #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/android-15-composer-2 - social-app PR #7412
Render
Destroyed
gaearon
reviewed
Jan 9, 2025
|
arcalinea
temporarily deployed
to
samuel/android-15-composer-2 - social-app PR #7412
Render
Destroyed
gaearon
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #7228
As far as I can tell,
KeyboardAvoidingViewis adding too much padding when the keyboard is closed on Android 15. We add a negative offset to theKeyboardAvoidingView, then remove the containing padding when the keyboard is open - seems to do the trick. We already do something similar for iOS.Button nav
Gesture nav
Android 11 (unchanged)
Web is unchanged, since this all hinges on safe area insets which don't exist on web
Test plan
Test the various combinations of Android version and Navigation mode, with keyboard open and closed